Skip to content

refactor: migrate debug info view models to metro [WPB-25946]#4887

Open
Garzas wants to merge 2 commits into
developfrom
refactor/settings-debug-metro-boundary
Open

refactor: migrate debug info view models to metro [WPB-25946]#4887
Garzas wants to merge 2 commits into
developfrom
refactor/settings-debug-metro-boundary

Conversation

@Garzas
Copy link
Copy Markdown
Contributor

@Garzas Garzas commented May 29, 2026

https://wearezeta.atlassian.net/browse/WPB-25946


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Migrates debug, about, dependencies, licenses, and what's-new ViewModel creation to the Metro ViewModel boundary.
  • Adds DebugInfoViewModelFactory and DebugInfoViewModelGraph.
  • Wires the new graph through WireActivityViewModelGraphBridge.
  • Removes Hilt ViewModel annotations and Hilt Compose call sites from this slice.

@Garzas Garzas self-assigned this May 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 5.31915% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.51%. Comparing base (9723544) to head (d6055d0).

Files with missing lines Patch % Lines
...wire/android/ui/debug/DebugInfoViewModelFactory.kt 0.00% 81 Missing ⚠️
...ttings/about/dependencies/DependenciesViewModel.kt 0.00% 2 Missing ⚠️
...android/ui/settings/about/AboutThisAppViewModel.kt 0.00% 2 Missing ⚠️
...om/wire/android/ui/debug/LogManagementViewModel.kt 0.00% 1 Missing ⚠️
...in/com/wire/android/ui/debug/UserDebugViewModel.kt 0.00% 1 Missing ⚠️
...i/debug/featureflags/DebugFeatureFlagsViewModel.kt 0.00% 1 Missing ⚠️
.../home/settings/about/licenses/LicensesViewModel.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (5.31%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4887      +/-   ##
===========================================
- Coverage    51.71%   51.51%   -0.20%     
===========================================
  Files          616      617       +1     
  Lines        21454    21534      +80     
  Branches      3422     3422              
===========================================
  Hits         11094    11094              
- Misses        9334     9414      +80     
  Partials      1026     1026              
Files with missing lines Coverage Δ
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 56.28% <100.00%> (ø)
.../android/ui/debug/ExportObfuscatedCopyViewModel.kt 0.00% <ø> (ø)
...i/debug/conversation/DebugConversationViewModel.kt 46.60% <100.00%> (ø)
...ug/cryptostats/ConversationCryptoStatsViewModel.kt 89.23% <100.00%> (ø)
...wire/android/ui/home/whatsnew/WhatsNewViewModel.kt 73.91% <100.00%> (ø)
...om/wire/android/ui/debug/LogManagementViewModel.kt 0.00% <0.00%> (ø)
...in/com/wire/android/ui/debug/UserDebugViewModel.kt 0.00% <0.00%> (ø)
...i/debug/featureflags/DebugFeatureFlagsViewModel.kt 0.00% <0.00%> (ø)
.../home/settings/about/licenses/LicensesViewModel.kt 0.00% <0.00%> (ø)
...ttings/about/dependencies/DependenciesViewModel.kt 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9723544...d6055d0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant