Skip to content

Increased gw-status version size field #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vg-wp merged 3 commits into from
Aug 4, 2026
Merged

Increased gw-status version size field #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f6a0d8
Increased gw_version size to 128
vg-wp Aug 4, 2026
3ed0fe4
Update generated proto files
Aug 4, 2026
e4f9a08
Fixed WPC_PROTO_MAX_RESPONSE_SIZE & WPC_PROTO_MAX_EVENTSTATUS_SIZE
vg-wp Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/api/wpc_proto.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@
* wp_SetScratchpadTargetAndActionResp_size
* wp_UploadScratchpadResp_size
*/
#define WPC_PROTO_MAX_RESPONSE_SIZE (415 + WPC_PROTO_GENERIC_MESSAGE_OVERHEAD)
#define WPC_PROTO_MAX_RESPONSE_SIZE (515 + WPC_PROTO_GENERIC_MESSAGE_OVERHEAD)

/*
* Maximum size of an Event Status. It can be used as an hint
* to give a big enough buffer to @WPC_Proto_get_current_event_status
* or @onStackStatusReceived
* note : it should be higher than wp_StatusEvent_size, as it's a wp_GenericMessage
*/
#define WPC_PROTO_MAX_EVENTSTATUS_SIZE (520 + WPC_PROTO_GENERIC_MESSAGE_OVERHEAD)
#define WPC_PROTO_MAX_EVENTSTATUS_SIZE (620 + WPC_PROTO_GENERIC_MESSAGE_OVERHEAD)

/*
* Maximum size offset for data reception. Added to payload size, it can be used as an hint
Expand Down
2 changes: 1 addition & 1 deletion lib/wpc_proto/gen/generated_protos/config_message.pb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ PB_BIND(wp_SetConfigResp, wp_SetConfigResp, 2)
PB_BIND(wp_GetGwInfoReq, wp_GetGwInfoReq, AUTO)


PB_BIND(wp_GetGwInfoResp, wp_GetGwInfoResp, AUTO)
PB_BIND(wp_GetGwInfoResp, wp_GetGwInfoResp, 2)


PB_BIND(wp_SetConfigurationDataItemReq, wp_SetConfigurationDataItemReq, AUTO)
Expand Down
10 changes: 5 additions & 5 deletions lib/wpc_proto/gen/generated_protos/config_message.pb.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ typedef struct _wp_GatewayInfo {
char gw_model[64];
/* Optional gateway version (gateway manufacturer specific) */
bool has_gw_version;
char gw_version[32];
char gw_version[128];
/* API version implemented in the gateway
This field must be explicitly set from code and must be
the one defined in each released version.
Expand Down Expand Up @@ -200,7 +200,7 @@ typedef struct _wp_StatusEvent {
char gw_model[64];
/* Optional gateway version (gateway manufacturer specific) */
bool has_gw_version;
char gw_version[32];
char gw_version[128];
/* See GatewayInfo for details of this field */
bool has_max_scratchpad_size;
uint32_t max_scratchpad_size;
Expand Down Expand Up @@ -686,13 +686,13 @@ extern const pb_msgdesc_t wp_GetConfigurationDataItemResp_msg;
#define wp_AppConfigData_size 94
#define wp_ChannelRange_size 12
#define wp_ConfigurationDataItem_size 137
#define wp_GatewayInfo_size 125
#define wp_GatewayInfo_size 222
#define wp_GetConfigsReq_size 41
#define wp_GetConfigsResp_size 415
#define wp_GetConfigurationDataItemReq_size 47
#define wp_GetConfigurationDataItemResp_size 225
#define wp_GetGwInfoReq_size 41
#define wp_GetGwInfoResp_size 212
#define wp_GetGwInfoResp_size 310
#define wp_NetworkKeys_size 36
#define wp_NodeRole_size 6
#define wp_SecurityKeys_size 42
Expand All @@ -702,7 +702,7 @@ extern const pb_msgdesc_t wp_GetConfigurationDataItemResp_msg;
#define wp_SetConfigurationDataItemResp_size 85
#define wp_SinkNewConfig_size 292
#define wp_SinkReadConfig_size 326
#define wp_StatusEvent_size 520
#define wp_StatusEvent_size 617

#ifdef __cplusplus
} /* extern "C" */
Expand Down
4 changes: 2 additions & 2 deletions lib/wpc_proto/proto_options/config_message.options
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ wp.SinkReadConfig.sink_id max_size:16
wp.SinkReadConfig.configuration_data_content max_count:0 // No support yet for CDD_API
wp.SinkNewConfig.sink_id max_size:16
wp.GatewayInfo.gw_model max_size:64
wp.GatewayInfo.gw_version max_size:32
wp.GatewayInfo.gw_version max_size:128
wp.GatewayInfo.gw_features max_count:2 // Only CHUNK + VIRTUAL_NODE
wp.StatusEvent.configs max_count:1 // only one sink
wp.StatusEvent.gw_model max_size:64
wp.StatusEvent.gw_version max_size:32
wp.StatusEvent.gw_version max_size:128
wp.StatusEvent.gw_features max_count:2
wp.GetConfigsResp.configs max_count:1 // only one sink
wp.ConfigurationDataItem.payload max_size:128 // Not used for now
Expand Down
Loading