fix: align course instances with academic calendar - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Course exports currently shift TIS week bitmaps by one week, use obsolete afternoon/evening period times for fall 2026, and ignore holiday/makeup dates. This change corrects the bitmap sentinel, applies the fall 2026 period table while retaining historical dates, and shares calendar-adjusted occurrences between ICS export and live course reminders.
Tests cover the bitmap sentinel, current versus historical period tables, holiday suppression, odd-week makeup classes, and live reminders on adjusted dates. Exports report partial coverage when calendar adjustments are unavailable.
Validation: original focused tests passed 50/50. Integration with current main builds and passes 316 of 317 tests in the sandbox; the remaining public-calendar test passes separately with network access. All 317 tests are accounted for.