Warlock: Improve Life Tap and Pet Resource Handling#170
Open
jannickj wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey :D
Not sure if the project is dead but i tried to use it and it was quite good but I ran into DS/Ruin being by far the best build because it assumes life tap with infinite healing. I tried to run some Pre-raid BIS experiments and this is what I got.
All the changes I did is listed below:
Life Tap
Life Tap now removes health when restoring mana and cannot be cast when the Warlock does not have enough health to pay its cost.
A dedicated Life Tap settings section adds:
These changes make health a meaningful constraint for Life Tap rotations without requiring a full raid-healing simulation.
Pets