Skip to content

Warlock: Improve Life Tap and Pet Resource Handling#170

Open
jannickj wants to merge 6 commits into
wowsims:masterfrom
jannickj:warlock-sim-fix-life-tap
Open

Warlock: Improve Life Tap and Pet Resource Handling#170
jannickj wants to merge 6 commits into
wowsims:masterfrom
jannickj:warlock-sim-fix-life-tap

Conversation

@jannickj

Copy link
Copy Markdown

Hey :D
Not sure if the project is dead but i tried to use it and it was quite good but I ran into DS/Ruin being by far the best build because it assumes life tap with infinite healing. I tried to run some Pre-raid BIS experiments and this is what I got.

image

All the changes I did is listed below:

Life Tap

Life Tap now removes health when restoring mana and cannot be cast when the Warlock does not have enough health to pay its cost.

A dedicated Life Tap settings section adds:

  • Ignore Life Tap Damage for simulations where health management is intentionally excluded.
  • Assumed Healing per Second for modeling incoming healing during an encounter.
  • A conservative default of 50 HPS, applied at roughly three-second intervals with some variation.
  • Support for negative values to model net incoming damage.

These changes make health a meaningful constraint for Life Tap rotations without requiring a full raid-healing simulation.

Pets

  • Add a passive pet option that prevents pet attacks and ability usage.
  • Display pet mana in the timeline even when the pet has no casts.
    • This makes pet mana behavior easier to inspect, particularly for rotations using Dark Pact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant