Update extract.custom parameter descriptions - #1062
Open
ebhills wants to merge 2 commits into
Open
Conversation
- added missing params to core wrangle doc strings - incorporated new multi-match capability into recipe wrangle schema
- add output to required. Never advise to extract into the input column because generally this converts a str to a list - sequenced the 3 required params as they be expected
Collaborator
Author
|
Queue triage (2026-07-27)
GitHub is the status record; update this PR rather than the external spreadsheet. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates extract.custom documentation and recipe schema for multi-match behavior.
Changes:
- Documents multi-match outputs and optional parameters.
- Corrects schema property descriptions.
- Marks
outputas required in the generated schema.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
wrangles/recipe_wrangles/extract.py |
Updates recipe schema and parameter descriptions. |
wrangles/extract.py |
Expands the public function docstring. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| required: | ||
| - input | ||
| - model_id | ||
| - output |
Comment on lines
+593
to
+595
| description: |- | ||
| Get the first element from results. | ||
| If one matched span returns multiple values, only the first value after sorting is kept. |
Comment on lines
+468
to
+469
| :param first_element: Return only the first extracted value for each input. If the service returns | ||
| multiple values for one matched span, only the first value after sorting is kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.