feat(opy): support SpecVisibility.NEVER - #139
Merged
Merged
Conversation
Map OPY spectator visibility spellings to canonical Workshop enum members and preserve source diagnostics with oracle-backed coverage. Fixes #131
Teakowa
requested changes
Aug 31, 2026
Teakowa
left a comment
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
Major — crates/opy-rs/src/lower.rs:1165
This PR also maps SpecVisibility.ALWAYS to VISIBLE_ALWAYS. #131 explicitly makes changes to unrelated SpecVisibility members a non-goal; on the base revision, catalog validation only accepts the canonical member IDs, so this changes ALWAYS behavior rather than merely preserving it.
Keep #131 limited to the NEVER mapping. Any ALWAYS compatibility change needs separately approved scope.
Keep Issue #131 limited to the NEVER spelling and retain the existing ALWAYS diagnostic.
This was referenced Aug 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SpecVisibility.NEVERspelling to the canonical WorkshopVISIBLE_NEVERenum member.SpecVisibility.ALWAYSdiagnostic and update the crosshair corpus expectation to record its nexthudSubtextgap.Verification
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-targets --all-featurespython3 -m unittest discover -s compatibility/testscargo test --locked -p opy-rs --test differential -- --nocaptureFixes #131