Skip to content

fix(opy-compiler): lower declared macros before WIR - #86

Merged
Teakowa merged 1 commit into
mainfrom
codex/issue-85-preprocess-macro
Aug 29, 2026
Merged

fix(opy-compiler): lower declared macros before WIR#86
Teakowa merged 1 commit into
mainfrom
codex/issue-85-preprocess-macro

Conversation

@e54-bot

@e54-bot e54-bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expand declared OPY macros before canonical Workshop WIR lowering
  • preserve frontend HIR macro calls for semantic tooling
  • retain structured diagnostics for recursive and invalid macro expansion
  • add the include plus macro regression through the public compile path

Verification

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo test --workspace --all-targets --all-features
  • python3 -m unittest discover -s compatibility/tests
  • git diff --check

Refs #85

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against #85 scope and acceptance criteria. The owner-side macro expansion is correctly resolved before canonical WIR lowering, structured diagnostics are preserved for the demonstrated failure modes, and the public compile-path regression covers the reported include + macro case. CI is green. PR body was adjusted to Refs #85 so the issue remains open until the released owner contract is consumed and verified downstream by wright#228.

@Teakowa
Teakowa merged commit a12d64e into main Aug 29, 2026
4 checks passed
@Teakowa
Teakowa deleted the codex/issue-85-preprocess-macro branch August 29, 2026 05:11
This was referenced Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants