Skip to content

fix(opy-compiler): restore residual canonical WIR equivalence - #91

Merged
Teakowa merged 2 commits into
mainfrom
codex/issue-89-wir
Aug 29, 2026
Merged

fix(opy-compiler): restore residual canonical WIR equivalence#91
Teakowa merged 2 commits into
mainfrom
codex/issue-89-wir

Conversation

@e54-bot

@e54-bot e54-bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Align OPY array, vector, condition, and format lowering with the pinned canonical WIR contract.
  • Restore direct workshop-rs::roundtrip::equivalent coverage for all six OPY-owned Issue Restore canonical WIR equivalence for residual compiler lowering cases #89 residual fixtures.
  • Lower OverPy debug(...) through native Workshop createHudText actions and values, restoring direct equivalence for synthetic/control-flow; no Workshop Debug-carrier follow-up is required.
  • Update compatibility expectations and regression coverage.

Verification

  • cargo test --locked --workspace --all-targets --all-features
  • cargo clippy --locked --workspace --all-targets --all-features -- -D warnings
  • python3 -B -m unittest discover -s compatibility/tests
  • 51-fixture compiler corpus runner
  • OPY differential corpus test

Fixes #89

Align array, vector, condition, and format lowering with the pinned canonical WIR while preserving the explicit Workshop-owned Debug carrier gap.

Fixes #89

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synthetic/control-flow is still attributed to workshop-rs#123, but #123 is already closed and its approved canonical-carrier scope does not cover the remaining Debug divergence. Issue #89 requires a canonical Workshop follow-up with stable source attribution when equivalence cannot be restored here. Please either restore direct WIR equivalence for this fixture or create/reference the correctly scoped Workshop follow-up before closing #89.

Teakowa commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Ownership clarification: the remaining synthetic/control-flow divergence is OPY-owned. OverPy debug(...) is a source-language helper that must lower to native Workshop actions/values; it should not be treated as a missing canonical Workshop Debug carrier. Issue #89 has been updated accordingly. The existing review blocker still stands, but the required direction is to restore native-WIR equivalence here rather than create a Workshop Debug-carrier follow-up.

Expand debug helpers into the canonical Workshop HUD action/value graph and cover control-flow with direct WIR equivalence.

Fixes #89

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR body is stale: it still says synthetic/control-flow remains a Workshop-owned Debug carrier gap, while this revision correctly restores direct equivalence through OPY-owned debug(...) lowering. Update the summary to match the implemented ownership/contract before merging.

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Teakowa
Teakowa merged commit 2663d2e into main Aug 29, 2026
5 checks passed
@Teakowa
Teakowa deleted the codex/issue-89-wir branch August 29, 2026 20:12
This was referenced Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore canonical WIR equivalence for residual compiler lowering cases

2 participants