fix(parser): disambiguate canonical enum members - #125
Merged
Conversation
Teakowa
requested changes
Aug 29, 2026
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
crates/workshop-rs/tests/parser.rs: released_parse_contract_resolves_pinned_oracle_members only exercises en-US. #124 explicitly requires the selected canonical identity to be proven locale-independent; the existing zh-CN parser tests cover unrelated domains, so this contract is not protected for the affected ambiguity. Add a direct non-primary-locale regression through the released parser::parse path that resolves the affected member to the same canonical WIR identity.
Teakowa
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parser::parseuse the canonical catalog signature context by default.Visible ToandNonemembers to stable canonical WIR identities.Unsupporteddiagnostic.Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace --all-targets(270 tests, 24 suites)cargo run --locked -p workshop-rs --bin workshop-catalog-gen -- checkgit diff --checkFixes #124