feat(wir): validate canonical interop contracts - #127
Merged
Conversation
Teakowa
requested changes
Aug 29, 2026
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
crates/workshop-rs/src/validate.rs:is_member_assignment_target: the new valueInArray(memberAccess(...), index) branch accepts a target shape that AssignMember does not emit as a native member lvalue. AssignMember serializes the target through generic value emission, while parsed receiver.member[index] is already the 3-arg memberAccess shape covered by this PR. Restrict the accepted target to canonical memberAccess shapes, or add explicit valid native-lvalue emission plus round-trip evidence for the valueInArray form if it is intentionally part of the contract.
Teakowa
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue
Fixes #123
Verification
All local gates passed. Hosted checks are not claimed until GitHub reports their final status.
Boundary
No OPY-specific WIR nodes or semantics were added. The dictionary literal and nested/multiple switch-shape lowering decisions remain owned by opy-rs; native Workshop indexed/member and control-flow primitives are now directly validated in workshop-rs.