Skip to content

fix(release): namespace R2 publication #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Teakowa merged 1 commit into from
Sep 9, 2026
Merged

fix(release): namespace R2 publication #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,21 +467,19 @@ jobs:
actual_hash="$(sha256sum "${archive}" | awk 'NR == 1 { print $1 }')"
test "${actual_hash}" = "${expected_hash}"
name="$(basename "${archive}")"
for prefix in "releases/${VERSION}" latest; do
put_immutable "${archive}" "${prefix}/${name}" 'public, max-age=31536000, immutable' 'application/octet-stream'
put_immutable "${checksum}" "${prefix}/${name}.sha256" 'public, max-age=31536000, immutable' 'text/plain; charset=utf-8'
verify_public "${prefix}/${name}" "${archive}" 'max-age=31536000.*immutable'
verify_public "${prefix}/${name}.sha256" "${checksum}" 'max-age=31536000.*immutable'
done
put_immutable "${archive}" "wright/releases/${VERSION}/${name}" 'public, max-age=31536000, immutable' 'application/octet-stream'
put_immutable "${checksum}" "wright/releases/${VERSION}/${name}.sha256" 'public, max-age=31536000, immutable' 'text/plain; charset=utf-8'
verify_public "wright/releases/${VERSION}/${name}" "${archive}" 'max-age=31536000.*immutable'
verify_public "wright/releases/${VERSION}/${name}.sha256" "${checksum}" 'max-age=31536000.*immutable'
done

printf '%s\n' "${VERSION}" > "${GITHUB_WORKSPACE}/latest-version"
aws s3api put-object \
--bucket "${R2_BUCKET}" \
--key latest/version \
--key wright/latest/version \

@Teakowa Teakowa Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: do not add install.sh or fixture changes to this publisher-only PR. The independent publisher/consumer split is intentional. The safe cutover should be handled operationally: merge this publisher contract, backfill the currently published Wright release into wright/releases/<version>/... and create wright/latest/version from that verified release without deleting the existing root-level objects, then rerun #285 against the production namespaced endpoint. After #285 lands, future releases can advance only the namespaced contract. No dual-write or installer change is required in #291.

--body "${GITHUB_WORKSPACE}/latest-version" \
--cache-control 'no-store, max-age=0' \
--content-type 'text/plain; charset=utf-8' \
--endpoint-url "${R2_ENDPOINT}" >/dev/null
verify_public latest/version "${GITHUB_WORKSPACE}/latest-version" 'no-store'
verify_public wright/latest/version "${GITHUB_WORKSPACE}/latest-version" 'no-store'
rm -f "${GITHUB_WORKSPACE}/latest-version"