Fix MLWH cache MySQL query premature closure - #587
Merged
Merged
Conversation
kjsanger
force-pushed
the
fix/mlwh-cache
branch
5 times, most recently
from
September 3, 2026 15:18
cb45c05 to
f55ed01
Compare
ce10-sanger
reviewed
Sep 9, 2026
mksanger
approved these changes
Sep 10, 2026
ce10-sanger
reviewed
Sep 10, 2026
ce10-sanger
reviewed
Sep 10, 2026
ce10-sanger
reviewed
Sep 10, 2026
kjsanger
force-pushed
the
fix/mlwh-cache
branch
from
September 10, 2026 15:48
07410d6 to
3b10e09
Compare
ce10-sanger
reviewed
Sep 14, 2026
New queries were being attempted against MySQL while an earlier query was still streaming results, resulting in only the first chunk of results being processed. Refactor the cache to avoid this. Improve maintainability by removing repeated string literals. Change from sample_id/study_id to sample_uuid/study_uuid.
Revert to using Study ID for study queries because Study UUIDs are not available in iRODS.
kjsanger
force-pushed
the
fix/mlwh-cache
branch
from
September 14, 2026 15:14
cbcd7a6 to
e7b0e2b
Compare
ce10-sanger
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New queries were being attempted against MySQL while an earlier query was still streaming results, resulting in only the first chunk of results being processed.
Refactor the cache to avoid this.
Improve maintainability by removing repeated string literals.
Change from sample_id/study_id to sample_uuid/study_uuid.