Add get-recently-created-directories - #589
Merged
ce10-sanger merged 4 commits intoSep 14, 2026
Merged
ce10-sanger merged 4 commits into
ce10-sanger merged 4 commits into
Conversation
ce10-sanger
changed the title
ce10-sanger
changed the title
See get-recently-created-directories description and epilog for context
ce10-sanger
force-pushed
the
NPG-4205-get-recently-changed-directories
branch
from
September 9, 2026 15:16
1d36f96 to
cff8606
Compare
ce10-sanger
changed the title
ce10-sanger
marked this pull request as ready for review
September 9, 2026 15:17
mksanger
approved these changes
Sep 10, 2026
mksanger
left a comment
mksanger
left a comment
Contributor
There was a problem hiding this comment.
All looks good, assuming it's been fully tested in the appropriate environment
| SECOND_SUNDAY_3AM = datetime(2024, 1, 14, 3, 0, 0, tzinfo=UTC) | ||
|
|
||
|
|
||
| class FakeFilesystem: |
Contributor
There was a problem hiding this comment.
A mock is never 100% equivalent, have you run some tests without this on the actual filesystem? Or at least checked all the same cases manually, there?
Contributor
Author
There was a problem hiding this comment.
Yep important point :)
(apologies forgot to include what manual testing I'd been doing)
I've been manually testing this within an integration solution for xenium publishing (some parts not yet ready for review) including cases where files modified some time after initial creation
Co-authored-by: mksanger <73285932+mksanger@users.noreply.github.com>
Contributor
Author
Cheers for the review @mksanger :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets recently created directories.
See command description (https://github.com/wtsi-npg/npg-irods-python/pull/589/changes#diff-287bd58148d629521de6e41fbf22aa5b86193781d6104f947a55886dacf27856R45) and epilog (https://github.com/wtsi-npg/npg-irods-python/pull/589/changes#diff-287bd58148d629521de6e41fbf22aa5b86193781d6104f947a55886dacf27856R66) for more MR context
Achieves https://jira.sanger.ac.uk/browse/NPG-4205, split from https://jira.sanger.ac.uk/browse/NPG-4028
Working towards nightly Xenium publish https://gitlab.internal.sanger.ac.uk/npg/npg_crontabs/-/merge_requests/141