Codex/headless introspection#89
Open
Akiva-Notkin wants to merge 5 commits into
Open
Conversation
… deadlocks Add PumpUntilCompleted helper that pumps the sync context while waiting for a Task to complete, avoiding deadlock from blocking on .GetResult() on the main thread. Apply it to FinalizeStartingRelics, EnterAct (in StartRun), and EnterRoom. Also harden EnterRoom with a pre-pump and a defensive MapRoom transition (matching the upstream ForceToMap convention) so direct combat entry from setup_combat works after StartRun+Neow leaves CurrentRoom as an EventRoom.
…tream API Match the upstream API rename; the old name is no longer present on RunManager.
Lets callers skip the Neow blessing event (default true for backward compat). Useful for direct-combat setups that go straight to the map.
Lets callers start a run, skip Neow (via the new neow parameter), and enter a specific combat encounter directly — bypassing the map. Accepts overrides for HP, gold, and (note: deck/relics are managed by start_run and cannot be safely overridden post-hoc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.