fix: use one-arg import.meta.resolve for Bun compatibility - #2607
Open
bompus wants to merge 1 commit into
Open
Conversation
Bun's two-arg import.meta.resolve(specifier, parent) fails for bare package names (Cannot find package 'wxt' / '@wxt-dev/…'). One-arg resolve works on both Bun and Node, so WXT CLI can run under bun --bun / bunx --bun.
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
pkg/wxt
Author
|
Companion Bun issue for the two-arg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import.meta.resolve(specifier, parent)fails for bare package names (Cannot find package 'wxt'when resolving from inside the package, and the same for WXT modules with a synthetic…/index.jsparent).resolveWxtModuleDirandresolveWxtUserModulesto one-argimport.meta.resolve, which works on both Bun and Node.bunx --bun wxt/bun --bunrun the WXT CLI (verified: HMR + production build).Related
import.meta.resolvepackage-name failures.Test plan
bunx --bun wxt --helpin a project that depends onwxtbunx --bun wxt(dev) starts withoutCannot find package 'wxt'@wxt-dev/unocss(or othermodules:) still loads modules under Bun and Nodenpx wxt/node …/wxt.mjsstill works