bugfix: copy complete HCCL header dependencies. - #32
Open
jarvis666666 wants to merge 2 commits into
Open
Conversation
- Detect the optional moe_distribute_comm_ctx.h dependency from the CANN base header. - Copy the complete HCCL header set to every MC2 consumer directory. - Fail early when a declared sibling dependency is unavailable.
- migrate op host code to the public ops_log interface - remove the CANN logging compatibility shim - eliminate the transitive log/log.h dependency from platform_util.h - add public logging definitions for common and ONNX plugin targets - update op generation templates to use public logging APIs Verified package builds with CANN 9.0 and CANN 9.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CANN 9.1 changes the internal moe_distribute_base.h dependency layout.
The header may include moe_distribute_comm_ctx.h, while the existing build
script copies only moe_distribute_base.h. This leaves an incomplete header
dependency closure and causes custom MC2 operator compilation to fail.
moe_distribute_comm_ctx.h.
hard-coding CANN 9.0 or CANN 9.1 paths.
dependency.
This is a compatibility fix for the current dependency on CANN internal
headers. A future change will replace these private header dependencies with
supported public CANN interfaces.