Skip to content

Stop age-gating from requiring media on gore-and-violence labels #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pitchfork-and-Torch wants to merge 1 commit into from
Closed

Stop age-gating from requiring media on gore-and-violence labels #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions visibility-filtering/rules/golden_corpus.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,30 @@ fn age_gating_cases() -> Vec<Case> {
expected_action: Allow,
expected_decided_by: None,
},
Case {
name: "underage_viewer_drops_gore_without_media",
level: TimelineHome,
viewer: viewer_with_age(ViewerAge::Known(15)),
candidate: labeled(SafetyLabelType::GORE_AND_VIOLENCE_HIGH_PRECISION),
expected_action: Drop(FilteredReason::ContainNsfwMedia),
expected_decided_by: Some("SensitiveViewerUnderageDropRule"),
},
Case {
name: "logged_out_viewer_drops_gore_without_media",
level: TimelineHome,
viewer: logged_out_viewer(),
candidate: labeled(SafetyLabelType::GORE_AND_VIOLENCE_HIGH_PRECISION),
expected_action: Drop(FilteredReason::ContainNsfwMedia),
expected_decided_by: Some("SensitiveViewerLoggedOutDropRule"),
},
Case {
name: "no_stated_age_in_gating_country_drops_gore_without_media",
level: TimelineHome,
viewer: no_stated_age_viewer("gb"),
candidate: labeled(SafetyLabelType::GORE_AND_VIOLENCE_HIGH_PRECISION),
expected_action: Drop(FilteredReason::ContainNsfwMedia),
expected_decided_by: Some("SensitiveViewerNoStatedAgeDropRule"),
},
]
}

Expand Down
22 changes: 21 additions & 1 deletion visibility-filtering/rules/tweet_rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,8 @@ fn nsfw_no_media_label_condition(context: &RuleContext<'_>) -> bool {
let tweet = context.tweet();
!context.viewer().is_author()
&& (tweet.has_safety_label(SafetyLabelType::NSFW_TEXT)
|| tweet.has_safety_label(SafetyLabelType::NSFW_CARD_IMAGE))
|| tweet.has_safety_label(SafetyLabelType::NSFW_CARD_IMAGE)
|| tweet.has_safety_label(SafetyLabelType::GORE_AND_VIOLENCE_HIGH_PRECISION))
}

fn sensitive_base_condition(context: &RuleContext<'_>) -> bool {
Expand Down Expand Up @@ -629,6 +630,7 @@ mod tests {
media_label(SafetyLabelType::GORE_AND_VIOLENCE_HIGH_PRECISION),
no_media_label(SafetyLabelType::NSFW_TEXT),
no_media_label(SafetyLabelType::NSFW_CARD_IMAGE),
no_media_label(SafetyLabelType::GORE_AND_VIOLENCE_HIGH_PRECISION),
nsfw_author_media(),
admin_author,
nsfw_tweet_flag_media(),
Expand Down Expand Up @@ -701,6 +703,24 @@ mod tests {
..gating_viewer(ViewerAge::Unknown)
};
assert_allows(logged_out, &logged_out_viewer, &hp_no_media);

let gore_no_media = no_media_label(SafetyLabelType::GORE_AND_VIOLENCE_HIGH_PRECISION);
assert_drops(
underage,
&gating_viewer(ViewerAge::Known(15)),
&gore_no_media,
&reason,
);
assert_drops(logged_out, &logged_out_viewer, &gore_no_media, &reason);
assert_drops(
no_age,
&gating_viewer(ViewerAge::NotStated),
&gore_no_media,
&reason,
);
let mut gore_self = gore_no_media.clone();
gore_self.author_id = VIEWER_ID;
assert_allows(underage, &gating_viewer(ViewerAge::Known(15)), &gore_self);
assert_allows(logged_out, &gating_viewer(ViewerAge::Known(15)), &hp);

let mut no_flags = nsfw_tweet_flag_media();
Expand Down