Fail closed when exclusive-content TES lookup errors - #209
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
VF
ExclusiveContentHydratorasks TESget_exclusive_controls, then treats RPCErrand timeout the same as "this tweet is not exclusive."DropExclusiveTweetContentRuleonly drops whenexclusive_content.is_some().timed_rpcon timeout returns an empty map (T::default()). Per-id TESErris dropped by.ok(). Assemble then storesNone.is_exclusive()is false, so the rule Allows.TES
Ok(None)still means the tweet is public. That path is unchanged.This is not #7 (author/graph fail-open). Not #24 (safety labels / TES nsfw-nullcast-takedown flags). Not #208 (mixer SubscriptionHydrator wrapper id). Exclusive hydration is a third TES call with no fail-closed bit.
ExclusiveContentHydrator::hydrate/timed_rpc("get_exclusive_controls")DropExclusiveTweetContentRule(!is_exclusive() => Allow)Noneexclusive featuressafety_hydration_failedfirst-position dropFix
Map TES
Errand hydrator timeout toExclusiveHydration::Failed. WireExclusiveHydrationFailureDropRuleimmediately beforeDropExclusiveTweetContentRuleon TimelineHome and TimelineHomeRecommendations. Drop withFilteredReason::ExclusiveTweet.Successful empty TES map stays public. Super-follower Allow on a successful exclusive TES hit is unchanged.
Tests
Ok(None)stays PublicOk(Some(author))stays ExclusiveErris Failedcargo testcannot run. Public dump has no visibility-filtering manifest. Verification of the change is on you.