fix: skip property_get for callable expressions during hover#1119
Open
DrSAS wants to merge 1 commit intoxdebug:mainfrom
Open
fix: skip property_get for callable expressions during hover#1119DrSAS wants to merge 1 commit intoxdebug:mainfrom
DrSAS wants to merge 1 commit intoxdebug:mainfrom
Conversation
7c15b84 to
bf5a07f
Compare
bf5a07f to
c5dd684
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1118
Problem
When hovering over a method call like
$this->compute($value)during a breakpoint, the adapter sends aproperty_getcommand. This triggers__get()on the server side, producing unwanted PHP Notices before the TypeScript catch block can intervene.Solution
Added
isHoverOnCallable()which reads the source line and checks if the hovered expression is immediately followed by parentheses. If so, the evaluate request is rejected early — noproperty_getis sent.Changes
EvaluateArgsWithSourceinterface for typed access tosourceisHoverOnCallable()private helper onPhpDebugSessionevaluateRequestfor hover contextTested manually
$this->compute(...)$this->cache$model()vscode-remote://)