Optimise row parser to delay sub-binary creation#192
Open
samsondav wants to merge 1 commit intoxerions:masterfrom
Open
Optimise row parser to delay sub-binary creation#192samsondav wants to merge 1 commit intoxerions:masterfrom
samsondav wants to merge 1 commit intoxerions:masterfrom
Conversation
1421518 to
d4337e7
Compare
Member
|
Hi @samphilipd, can you explain your changes? |
Author
|
@surik Sort of. I don't know why this works, but with this change three "NOT OPTIMIZED" becomes "OPTIMIZED" in the output when |
Member
|
I'm not sure that it gives something expect some changes in compiler output with |
Contributor
|
This change prevents a binary reference being created when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.