Skip to content

Optimise row parser to delay sub-binary creation#192

Open
samsondav wants to merge 1 commit intoxerions:masterfrom
samsondav:row_parser_optimisations
Open

Optimise row parser to delay sub-binary creation#192
samsondav wants to merge 1 commit intoxerions:masterfrom
samsondav:row_parser_optimisations

Conversation

@samsondav
Copy link
Copy Markdown

No description provided.

@samsondav samsondav force-pushed the row_parser_optimisations branch from 1421518 to d4337e7 Compare July 12, 2017 15:33
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 12, 2017

Coverage Status

Coverage remained the same at 65.616% when pulling d4337e7 on samphilipd:row_parser_optimisations into 0e02865 on xerions:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 12, 2017

Coverage Status

Coverage increased (+0.1%) to 65.753% when pulling d4337e7 on samphilipd:row_parser_optimisations into 0e02865 on xerions:master.

@samsondav samsondav closed this Jul 14, 2017
@samsondav samsondav reopened this Jul 14, 2017
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 14, 2017

Coverage Status

Coverage remained the same at 65.616% when pulling d4337e7 on samphilipd:row_parser_optimisations into 0e02865 on xerions:master.

@surik
Copy link
Copy Markdown
Member

surik commented Jul 17, 2017

Hi @samphilipd, can you explain your changes?

@samsondav
Copy link
Copy Markdown
Author

@surik Sort of. I don't know why this works, but with this change three "NOT OPTIMIZED" becomes "OPTIMIZED" in the output when @compile :bin_opt_info is set.

@surik
Copy link
Copy Markdown
Member

surik commented Jul 17, 2017

I'm not sure that it gives something expect some changes in compiler output with bin_opt_info option.

@fishcakez
Copy link
Copy Markdown
Contributor

fishcakez commented Oct 19, 2017

This change prevents a binary reference being created when decode_text_part is called in the tail of decode_text_rows but not other functions in this change. In the other cases it simply delays the reference being created to next call. It works for those cases as no pattern matching to left of the rest arg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants