Make default character set consistent#233
Conversation
|
The behaviour of this change has no effect on everything issued after the mariaex/lib/mariaex/protocol.ex Lines 219 to 221 in 5ef4656 |
|
Setting the actual proper default charset is quite a challenge since you need the internal charset nr (which is some rune from a generated IndexFile on the server side and is version specific):
Setting it to UTF-8 is not the true solution, perhaps this just needs to be 'known' by users of MariaEX: you need to specify an explicit charset else you will get the hard coded default not the database default. cc @michalmuskala @josevalim Perhaps a warning/exception would be in order in those places. |
In MariaEx, the default character set defaults to
utf8. However, the initial client negotiation (the first client response after theserver greeting) is currently hardcoded at character set 8 (which islatin1 COLLATE latin1_swedish_ci):To make the behaviour of MariaEx consistent, this PR changes the initial client negotiation to character set 33 (which is
utf8 COLLATE utf8_general_ci).