feat(session): sync compose-bar images and files with desktop drafts - #7
Open
Adam-Dalloul wants to merge 2 commits into
Open
feat(session): sync compose-bar images and files with desktop drafts#7Adam-Dalloul wants to merge 2 commits into
Adam-Dalloul wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order
#479(draft endpoints)#6(text-only compose-bar sync)#483(attachment-ref API)#7)This branch already contains iOS
#6. Merge#6first so this reviews as the attachment delta. The desktop attachment API is#483.The iOS compose bar now:
/upload_attachmentand PUTs the jail ref with the draft textread_upload_attachment(thumbnail locally; send uses emptyimagedata +file://so the server re-inlines)file://refs and sendsresource_linkattachmentsuntil the first GET so an older desktop cannot be wipedWS notify stays ids-only. No secrets. One extra concern on top of
#6.