Skip to content

fix(web-vue): Button rendered a <div> — clicks could not submit forms #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xirothedev merged 1 commit into from
Sep 6, 2026
Merged

fix(web-vue): Button rendered a <div> — clicks could not submit forms #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/web-vue/src/components/ui/button.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ export function Button(props: ButtonProps, { attrs, slots }: any): VNode {
return h(
Primitive,
{
// Primitive defaults to <div>, which cannot submit forms or receive disabled.
// asChild=true swaps the element for the slot child; plain type="button" keeps
// in-form buttons from implicitly submitting.
as: 'button',
type: 'button',
...attrs,
'data-slot': 'button',
'data-variant': variant ?? 'default',
Expand Down
Loading