chore: LocalStack-only cleanup (drop real-AWS probe/bootstrap; ECR us-east-1) - #64
Merged
Conversation
…calStack only); pin ECR rehearsal to us-east-1 (TLS cert coverage)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project is LocalStack-only — there is no real AWS account in play (the
aws loginbrowser flow that briefly appeared was a wrong read of "full"; that link is AWS's own console sign-in and is not needed here).Removes the three real-AWS-only artifacts added today:
.github/workflows/aws-probe.yml— probes real OIDC/ECR/CFN; nothing to probescripts/aws/one-time-aws-admin.sh+scripts/aws/first-deploy.sh— bootstrap real IAM/OIDC/ACM; not applicableAlso:
scripts/localstack/ecr-rehearsal-push.shpinned to us-east-1 — the emulator's default TLS cert SANs cover*.dkr.ecr.us-east-1.localhost.localstack.cloudbut notap-southeast-1, so image pushes referenced by ap-southeast-1 task defs fail with x509 errors. LocalStack infra rehearsal must live in us-east-1.Verified: script re-pushes all 5 images and
describe-imagesconfirms them.