Show the whole link in the wizard's question dialog#33
Open
xroche wants to merge 1 commit into
Open
Conversation
An LTEXT static only wraps at whitespace, so a URL is a single unbreakable word: the wizard's question dialog clipped it at one line with no ellipsis, leaving no way to tell which link the question was about. Use a read-only multiline edit, which breaks a long word at a character boundary, and widen the dialog. A static also eats & as an accelerator prefix, so query-string URLs rendered wrong; an edit does not. The groupbox was IDC_STATIC, making the SetDlgItemTextCP(IDC_STATIC_rule, LANG_M2) call in WizLinks.cpp a no-op that never translated. Give it the ID the code already expects, and label it "Choose a rule" as lang.def defines LANG_M2: it wraps the radio buttons, not the URL. Closes #277 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Download web site(s) + questions" dialog showed only as much of the URL as fit on one line, which left no way to judge the link you were being asked about. The link lived in an
LTEXTstatic, and a static only wraps at whitespace, so a URL is one unbreakable word and gets clipped with no ellipsis. It is now a read-only multiline edit, which breaks a long word at a character boundary, and the dialog is wider. That also drops an unreported bug for free: a static treats&as an accelerator prefix, so&x=in a query string used to render as an underlinedx=.The groupbox around the radio buttons was
IDC_STATIC, so theSetDlgItemTextCP(this, IDC_STATIC_rule, LANG_M2)inWizLinks.cpphad been a silent no-op and the box never translated. It carries the right ID now, and its English label matches whatlang.defhas always saidLANG_M2is ("Choose a rule") rather than "Link:", which described the URL that sits outside the box. Resource-only apart from that ID. Rendering needs an eyeball on a VM: CI compiles and links the dialog but cannot see it.Closes #277