Say which file type the installer associates, and honour the choice#34
Merged
Conversation
The setup's file-types task named no extension, so the user could not tell what unchecking it would cost. Name it: .whtt, plus the Explorer "New > WinHTTrack Project" entry. Unchecking it did not prevent the association anyway. The task only writes uninstall markers and SetupHasRegistered, while RegisterShellFileTypes() ran unconditionally in InitInstance. Gate it on the condition that already guarded the ShellNew entry, so a portable run associates as before and an installed one obeys the checkbox. Closes #187 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup's file-types checkbox named no extension, so there was no way to decide whether to want it. It now says what it does: it associates
.whttand adds the Explorer "New > WinHTTrack Project" entry.Unchecking it did not actually prevent the association. The installer's task only writes uninstall markers and
SetupHasRegistered; the association itself isRegisterShellFileTypes()inWinHTTrack.cpp, which ran unconditionally. It is now gated on the same condition that already guarded theShellNewentry, so a portable run still associates and an installed one obeys the checkbox. Naming the extension without this would have made the label precise and still wrong. The installer has no[Languages]or[CustomMessages]section, so there is no translated copy of this string to update.Closes #187