Show the selected language in the About box#35
Open
xroche wants to merge 1 commit into
Open
Conversation
The language field was empty for six languages. The selection loop compared the combo text against LANGUAGE_NAME, but the combo is filled from LANG_LOAD's out-parameter, which returns the lang/<name>.txt basename, not the translated name inside the file: "Francais" never matches "Français", so SetCurSel(-1) stood. English only worked because both spellings agree. Items are added in language-index order, so select LANG_T(-1) directly. Affected Francais, Cesky, Croatian, Portugues, Portugues-Brasil and Uzbek. Refs #188 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The About box's language field was empty for six of the shipped languages. It picked the combo entry by comparing the item text against
LANGUAGE_NAME, but the combo is filled fromLANG_LOAD's out-parameter, which yields thelang/<name>.txtbasename, whileLANGUAGE_NAMEis the translated name inside that file.Francaisnever equalsFrançais, so the loop fell through and leftSetCurSel(-1). English matched only because its two spellings coincide.Affected: Francais, Cesky, Croatian, Portugues, Portugues-Brasil, Uzbek. The items are added in language-index order, so the selection is just
LANG_T(-1)and the comparison loop can go.OnSelchangelangcompares against the same basename and was always right, so it is untouched. Reported as part of #188, whose main symptom (corrupted tab labels after a language change) is a separate use-after-free and is not addressed here.Refs #188