WinHTTrack.exe still reports 3.49-12 after the engine bump to 3.49-13#36
Merged
Conversation
The engine released 3.49.13 and the Windows CI checks out xroche/httrack from master unpinned, so the new version reached the build immediately while WinHTTrack's own resource stayed at 3.49-12. Both arches now fail the version-agreement check before the installer is ever built. Bumps FILEVERSION, PRODUCTVERSION, FileVersion and ProductVersion. The version CI passes to ISCC is read from htsglobal.h at build time, so it needs no change here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine released 3.49.13, and the Windows CI checks out the engine from master unpinned, so the bump reached the build right away while
WinHTTrack.exe's own resource stayed at 3.49-12. Both arches now fail the version-agreement check, withhttrack.exeandlibhttrack.dllreporting 3.49-13 againstWinHTTrack.exe's 3.49-12. This bumps the four version fields inWinHTTrack.rc. The version CI hands to ISCC is read fromhtsglobal.hat build time and needed no change.The check runs before the installer is built, so a red master uploads only msbuild logs. There is nothing to stage for the mirror preview until this lands.