db: include backend kwargs in results metadata - #145
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Backend-specific options can affect generated code and performance, but were not recorded in the exploration results database. This could make results produced with different backend configurations indistinguishable.
Description
Update the results database format to v0.3 and include backend keyword arguments in compiler metadata.
Exploration configuration now maintains backend-specific keyword arguments, uses them when constructing backend implementations, and forwards them to the database callback. The database query interface accepts the same arguments when matching results.
Commits
db: update json db to format 0.3 with backend kwargsDiscussion
The database version is bumped from v0.2 to v0.3 because compiler metadata now includes backend keyword arguments.
Testing: Not run.