Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -1034,7 +1034,7 @@ class ModbusRTU extends EventEmitter {
}

const code = 15;
let i = 0;
let i;

// set state variables
this._transactions[this._port._transactionIdWrite] = {
Expand Down
125 changes: 34 additions & 91 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@
},
"homepage": "https://github.com/yaacov/node-modbus-serial#readme",
"devDependencies": {
"@eslint/js": "^9.39.1",
"chai": "^4.5.0",
"chai-as-promised": "^7.1.2",
"@eslint/js": "^10.0.1",
"chai": "^6.2.2",
"chai-as-promised": "^8.0.2",
"clean-jsdoc-theme": "^4.3.0",
"eslint": "^10.0.3",
"globals": "^16.5.0",
"globals": "^17.4.0",
"jsdoc": "^4.0.5",
"mocha": "^11.7.5",
"mockery": "^2.1.0",
Expand All @@ -63,7 +63,7 @@
"webbluetooth": "^3.6.0"
},
"dependencies": {
"debug": "^4.3.1"
"debug": "^4.4.3"
},
"optionalDependencies": {
"serialport": "^12.0.0"
Expand Down
2 changes: 1 addition & 1 deletion ports/asciiport.js
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ class AsciiPort extends EventEmitter {
return;
}

let length = null;
let length;

// remember current unit and command
this._id = data[0];
Expand Down
4 changes: 2 additions & 2 deletions ports/c701port.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class UdpPort extends EventEmitter {

// wait for answer
this._client.on("message", function(data) {
let buffer = null;
let buffer;

// check expected length
if (modbus.length < 6) return;
Expand Down Expand Up @@ -148,7 +148,7 @@ class UdpPort extends EventEmitter {
return;
}

let length = null;
let length;

// remember current unit and command
this._id = data[0];
Expand Down
2 changes: 1 addition & 1 deletion ports/rtubufferedport.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ class RTUBufferedPort extends EventEmitter {
return;
}

let length = null;
let length;

// remember current unit and command
this._id = data[0];
Expand Down
2 changes: 1 addition & 1 deletion ports/telnetport.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ class TelnetPort extends EventEmitter {
return;
}

let length = null;
let length;

// remember current unit and command
this._id = data[0];
Expand Down
12 changes: 6 additions & 6 deletions ports/testport.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ class TestPort extends EventEmitter {
* @param {Buffer} data
*/
write(data) {
let buffer = null;
let length = null;
let address = null;
let value = null;
let state = null;
let i = null;
let buffer;
let length;
let address;
let value;
let state;
let i;

if(data.length < MIN_DATA_LENGTH) {
modbusSerialDebug("expected length of data is to small - minimum is " + MIN_DATA_LENGTH);
Expand Down
7 changes: 4 additions & 3 deletions ports/udpport.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@ class ModbusUdpPort extends EventEmitter {
this.ip = ip;
this.openFlag = false;
this._transactionIdWrite = 1;
this.port = options.port || MODBUS_PORT;

// options
if (typeof(options) === "undefined") options = {};
if (typeof options === "undefined") {
options = {};
}
this.port = options.port || MODBUS_PORT;

// create a socket
this._client = dgram.createSocket("udp4");
Expand Down
6 changes: 3 additions & 3 deletions servers/servertcp_handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ function _handleReadCoilsOrInputDiscretes(requestBuffer, vector, unitID, callbac
msg: "Invalid length"
});

let i = 0;
let cb = null;
let promiseOrValue = null;
let i;
let cb;
let promiseOrValue;

if (isGetCoil && vector.getCoil.length === 3) {
for (i = 0; i < length; i++) {
Expand Down
3 changes: 2 additions & 1 deletion test/servers/servertcp.enron.test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
"use strict";

const chai = require("chai");
const chaiAsPromised = require("chai-as-promised");
const chaiAsPromisedModule = require("chai-as-promised");
const chaiAsPromised = chaiAsPromisedModule.default ?? chaiAsPromisedModule;
// Load chai-as-promised support
chai.use(chaiAsPromised);
// Initialise should API (attaches as a property on Object)
Expand Down
Loading