fix: add missing worker/ to files field#610
Conversation
The worker/ directory is required by apis/worker.js (require('../worker/index'))
but was omitted from the files field, causing v8.0.24 to fail at require time:
Error: Cannot find module '../worker/index'
This breaks all dependents using ^8.x ranges.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
|
@Dennis-SEG nice, thank you for the fast fix ! |
|
You're welcome. |
Summary
"worker"to thefilesarray inpackage.jsonProblem
v8.0.24 introduced a
filesfield inpackage.jsonbut omitted theworker/directory. Sinceapis/worker.jsrequires../worker/index, the package fails at load time:This breaks all dependents using
^8.xranges.v8.0.23:
worker/index.jsincluded (nofilesfield, so everything was packaged)v8.0.24:
worker/index.jsmissing (newfilesfield doesn't listworker)Fix
One-line change: add
"worker"to thefilesarray.Fixes #609
Summary by CodeRabbit