Add pytest-cov coverage reporting (informational, not a CI gate) - #267
Merged
Conversation
Add pytest-cov coverage reporting (informational, not a CI gate) Closes yakew7#249 - Add a `test` extra to pyproject.toml (pytest, pytest-cov) - Add a `make coverage` target; `make test` output is unchanged - CI's profiler job now runs with --cov=faircode --cov-report=term-missing No --cov-fail-under is set anywhere, so this can never fail a PR on a coverage threshold - it's visibility only, as requested in the issue. Baseline on this run: 82% overall coverage across faircode/. Weakest spots: figures.py (0%), cli.py (51%), report.py (64%), benchmark.py (72%) - good candidates for a follow-up issue. README coverage badge (mentioned as optional in yakew7#249) is not included here since it needs a live coverage service (Codecov/Coveralls) set up by the maintainer first.
Contributor
|
@Circout-sudo is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Requesting one clarification before approval: make setup now installs only .[test] instead of the previous .[excel,parquet,proxy] extras. Can we confirm this is intentional and that those existing contributor dependencies are not being dropped? |
Owner
|
@Circout-sudo could you reply to @ahmdkaml and fix the conflicts in the makefile pls |
yakew7
reviewed
Aug 16, 2026
yakew7
left a comment
Owner
There was a problem hiding this comment.
make setup now installs only .[test] instead of the previous .[excel,parquet,proxy] extras. is this intentional or no?
yakew7
added a commit
that referenced
this pull request
Aug 17, 2026
Two new merges since the last snapshot (#266): - #275 (evanjain-dot): the precision-recall-curve explainer (#92). 6 merged PRs, 28 commits now - stays in first place, further ahead. - #267 (Circout-sudo): a small Makefile refinement to the coverage target (comment clarity + a -q flag). 3 merged PRs, 3 commits now - moves their entry up from the tied-at-2 tier to its own position right after the two 4-PR contributors, per the count-based ordering established last time. Snapshot bumped to 2026-08-17 / PR #275. CHANGELOG entry added under the same pending version (2.0.11).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pytest-cov coverage reporting (informational, not a CI gate)
Closes #249
testextra to pyproject.toml (pytest, pytest-cov)make coveragetarget;make testoutput is unchangedNo --cov-fail-under is set anywhere, so this can never fail a PR on a coverage threshold - it's visibility only, as requested in the issue.
Baseline on this run: 82% overall coverage across faircode/. Weakest spots: figures.py (0%), cli.py (51%), report.py (64%), benchmark.py (72%) - good candidates for a follow-up issue.
README coverage badge (mentioned as optional in #249) is not included here since it needs a live coverage service (Codecov/Coveralls) set up by the maintainer first.
Summary
Type
Audit checklist
unfair.pyincludes protected attributes and prints the required output formatfair.pyremoves protected attributes and identified proxy variablesrandom_state=42and an 80/20 train/test splitunfair.pngandfair.pngare included as PNG screenshotsDATA.mdis included if the file is too largeREADME.mdincludes the new results row and audit sectionBefore fairness gap:
After fairness gap:
Reduction:
Protected attribute(s):
Proxy variables dropped:
Explainer checklist
explainers/and uses lowercase hyphenated namingREADME.mdwas updatedLinked issue
Closes #