Experimental: Implements a ZipFS on top of the native WIP PR#5145
Open
arcanis wants to merge 23 commits into
Open
Experimental: Implements a ZipFS on top of the native WIP PR#5145arcanis wants to merge 23 commits into
arcanis wants to merge 23 commits into
Conversation
arcanis
commented
Dec 18, 2022
Comment on lines
+64
to
+66
| "sharp": { | ||
| "built": false | ||
| }, |
Member
Author
There was a problem hiding this comment.
Sharp doesn't like building on fresh Node builds.
merceyz
requested changes
Jan 5, 2023
merceyz
left a comment
merceyz
left a comment
Member
There was a problem hiding this comment.
I don't think we should merge this until Node.js actually ships the API.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Since Yarn uses a lot of zip-related operations, it's a great way to benchmark nodejs/node#45651.
How did you fix it?
Implements a ZipFS implementation using the
archivemodule (only available when building nodejs/node#45651 from sources, so the CI is expected to fail at the moment).Checklist