web-ui: a bare arrow marks a link that leaves the app - #977
Open
evebouf wants to merge 1 commit into
Open
Conversation
The boxed ExternalLink glyph reads as a control with a frame around it, which is a heavier promise than "this opens elsewhere". ArrowUpRight says the same thing with one stroke, and it is already the mark the inbox uses for Open in Slack and the agent session link, so the app now has one signifier for leaving instead of two. Every call site moves together: both Settings rows and the deployment Open app button. Nothing else imported ExternalLink. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the boxed
ExternalLinkglyph forArrowUpRighton every link that opens outside the app.ExternalLinkis no longer imported anywhere inplugins/web-ui/srcArrowUpRightis already what the inbox uses for Open in Slack and the agent-session link, so this leaves one mark for "this leaves the app" instead of two.Before / after (Settings):
web-ui 939/939, typecheck and prettier clean.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.