Make Slack E2E assertions follow the intended behavior - #982
Open
ReganBell wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live Slack catalog should fail when the requested behavior fails, rather than because an otherwise valid response omits a synthetic marker, uses the channel top level, or follows an interim progress message. The file fixture uploader also wrapped a 1,336-byte PNG in a 1,556-byte multipart payload that a raw upload endpoint could store as image data.
Validation: 14 affected tests pass; typecheck, ESLint, and upstream CI pass. Independent review and its follow-up are complete. Regression coverage includes exact PNG bytes, thread metadata, channel/thread selection, delayed history answers, transient and persistent cleanup failures, and no POST replay. Live Arga replays have passed all four originally affected cases; the final history replay passed in 61 seconds. The full final catalog is still queued/running. Alerts and release gates remain enabled.