Tape parity: limited-read comparison uses the snapshot window - #994
Merged
Conversation
…shot's latest seq and expected to the tape's covered seq Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full-corpus parity check compares a session's entries and tape from one snapshot, but the limited-read comparison calls the live transcript source, which re-reads the store — so a turn landing between the script's snapshot and the serving read makes the served view newer than the expected list, and the trailing rows count as real mismatches. On an active fleet this produces a steady band of false reals per run (reproducibly, since the settle-recheck races the same ongoing activity).
Fix: compare only the intersection window — served rows clamped to the snapshot's latest seq, expected entries clamped to the tape's covered seq. A race-faithful pinning test (snapshot, then a live turn, then the limited comparison with the stale snapshot) is red on the old code.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.