fix: attribute shared-harness security calls as auxiliary - #996
Open
time-attack wants to merge 1 commit into
Open
fix: attribute shared-harness security calls as auxiliary#996time-attack wants to merge 1 commit into
time-attack wants to merge 1 commit into
Conversation
Mark isolated one-shot LLM requests with a null turn sequence, and apply the existing security-screen step only at the screen utility. Preserve per-call records and align Claude, Codex, and OpenCode with the Pi recording convention. Co-authored-by: Ian Chou <ertiach@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #889. Reported by @ianTPE from a running QM deployment.
The shared one-shot runner fabricated turn 1 and forwarded its LLM recorder unchanged. Security screens in the Claude, Codex, and OpenCode harnesses consequently appeared as steps of the real conversation's first turn, and were absent from the security-screen replay corpus.
This fixes the shared path once:
turnSeq: null.screenSecuritystamps the existingSECURITY_SCREEN_STEP, matching Pi and the mock harness.Validation
The new tests cover both generic one-shot attribution and screening-specific coordinates. The production change is confined to the shared harness helper.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.