fix: record metrics for ambient gate declines - #997
Open
time-attack wants to merge 1 commit into
Open
Conversation
Persist silent and reaction gate decisions with their run, session, scope, and detection timing. No answer harness runs, so leave totalMs at zero and retain pre-harness elapsed time in ingressMs. Co-authored-by: Ian Chou <ertiach@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the missing ambient-gate metrics in #609, reported by @ianTPE from a running QM deployment. This intentionally does not close the broader issue.
When the ambient reply gate chose silence or an emoji reaction, the orchestrator returned before writing a turn metric. Record one metric at that existing decision point, with the actual status, session, scope, optional run ID, and detection duration.
No answer harness runs on this path, so
totalMsis zero. Admission-to-decision time is recorded in the existingingressMsfield;detectMsremains its detection-phase subset. This preserves the meaning of completed-turn timing fields instead of mixing two time bases.Scope
Validation
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.