Yieldmo Bid Adapter: revert badv support (keep bcat) [FS-12411] - #66
Open
ym-aaron wants to merge 2 commits into
Open
Yieldmo Bid Adapter: revert badv support (keep bcat) [FS-12411]#66ym-aaron wants to merge 2 commits into
ym-aaron wants to merge 2 commits into
Conversation
Reverts the badv portions of prebid#14989 because a large publisher's long badv lists are materially hurting monetization (FS-12411). bcat is left fully intact (ortb2 + params merge on banner and video). badv is restored to its exact pre-prebid#14989 behavior: - banner GET no longer sends badv - video OpenRTB sends badv: bidRequests[0].params.badv || [] (no ortb2/merge) - params.badv array validation moves back into validateVideoParams (video-only) Docs and unit tests updated to match; getBlocklist retained for bcat. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Restore badv to the docs after the FS-12411 revert, but scoped to its actual reverted behavior: video-only, params source only (no ortb2, no banner). Documentation only; no code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Reverts the
badvportions of prebid#14989 (prebid/Prebid.js#14989). A large publisher who requestedbadvis sending very longbadvlists, which is materially hurting monetization (FS-12411, PS-7681).bcatis left fully intact (ortb2 + params merge, banner + video).badvis restored to its exact pre-prebid#14989 behavior:badv.badv: bidRequests[0].params.badv || [](noortb2source, no merge).params.badvarray validation moves back intovalidateVideoParams(video-only) — a non-arrayparams.badvdrops a video bid; bannerbadvis not validated.getBlocklistis retained becausebcatstill uses it (ortb2 + params union/dedupe).Files
modules/yieldmoBidAdapter.js— revert the fourbadvtouch-points listed above.modules/yieldmoBidAdapter.md— dropbadvfrom examples; blocklist section rewritten asbcat-only.test/spec/modules/yieldmoBidAdapter_spec.js— tests rewrittenbcat-only; added assertions that banner never sendsbadvand video sendsparams.badvonly.Test results
npx eslint 'modules/yieldmoBidAdapter.js' 'test/spec/modules/yieldmoBidAdapter_spec.js'— clean (exit 0).npx gulp test --nolint --file test/spec/modules/yieldmoBidAdapter_spec.js— 88 tests passed.Other information
This is the internal review PR. The upstream PR will go
yieldmo:FS-12411-revert-badv-agent→prebid/Prebid.js:master, mirroring how prebid#14989 was merged.🤖 Generated with Claude Code