Yieldmo Bid Adapter: recover tdid/pubcid/criteoId from userIdAsEids - #67
Open
ym-aaron wants to merge 2 commits into
Open
Yieldmo Bid Adapter: recover tdid/pubcid/criteoId from userIdAsEids#67ym-aaron wants to merge 2 commits into
ym-aaron wants to merge 2 commits into
Conversation
getId() read ids off the legacy bid.userId object, which Prebid removed in 10.0.0 (prebid#13253) in favor of userIdAsEids. On 10+ that made the adapter silently stop sending the tdid, pubcid and cri_prebid params on the banner request, degrading exchange-side paths that key on them (TTD real-time enrichment, internal pubcid, partner-id cookie match). Fall back to reading each id from userIdAsEids by source (adserver.org, pubcid.org, criteo.com) when bid.userId is absent, preferring the legacy object when present. Restores parity with 9.x on Prebid 10+. Refs PS-7862. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds a test built from a live getUserIdsAsEids() capture on www.yahoo.com (Prebid 9.53.2): a 13-source blob with a single adserver.org entry tagged rtiPartner TDID, a pubcid.org, no criteo, and 11 sources never read as flat params. Asserts tdid/pubcid are recovered from userIdAsEids on Prebid 10+, that cri_prebid is omitted (no criteo id), and that every EID source is still forwarded via the eids param. Refs PS-7862. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
getId()in the Yieldmo adapter readtdid/pubcid/criteoIdoff the legacybid.userIdobject. Prebid removedbid.userIdin 10.0.0 (prebid/Prebid.js#13253) in favor ofuserIdAsEids, so on Prebid 10+getId()returnsundefinedand the adapter silently stops sending thetdid,pubcidandcri_prebidparams on the banner (/exchange/prebid) request.The IDs still travel inside the
eidsblob, so DSP-facinguser.ext.eidsare unaffected — but the exchange keys a few paths specifically on the flat params (TheTradeDesk real-time enrichment lookup, the internalpubcididentifier, and the partner-id cookie-match contribution), and those have noeidsfallback. This surfaced during investigation of PS-7862 (Minute Media, 9.41 → 11.15).Fix: when
bid.userIdis absent, recover each id fromuserIdAsEidsby source (adserver.org→ tdid,pubcid.org→ pubcid,criteo.com→ criteoId). The legacy object is still preferred when present, so pre-10 behavior is unchanged. Restores byte-for-byte request parity with 9.x on Prebid 10+.Scope: banner GET path only. The video/openRTB path never used
bid.userId(it readsuserIdAsEidsdirectly) and is untouched.Testing
buildRequests > Banner > userIdAsEids fallbackcovering tdid/pubcid/criteoId recovery, legacy-object precedence, and the missing-source case.gulp test --file test/spec/modules/yieldmoBidAdapter_spec.js: 93 passing (run against the identical change on the current upstream checkout;getId/getEids/spec helpers are identical on this base).eslintclean on both changed files.Other information
Refs PS-7862.