fix: Ensure that the ancestor element is in the dom tree#76
Open
rainke wants to merge 1 commit into
Open
Conversation
some lib（https://www.npmjs.com/package/vue-frag）will create fake parentNode for element
Owner
|
需要一个出错例子。 另外直接在 getVisibleRectForElement 函数开头判断是不是就行了，不进入 while |
Author
|
https://github.com/rainke/align-demo vue-frag 导致其 child 的 parentNode 是一个不在文档流的元素, 需要跳过继续找祖先元素 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some lib（https://www.npmjs.com/package/vue-frag）will create fake parentNode for element