⚡ perf: Use requests.Session for connection pooling - #24
Conversation
- Initialized a global `requests.Session()` object in `create_worklog.py`. - Replaced standalone `requests.get` and `requests.post` calls with `session.get` and `session.post` to enable HTTP connection pooling. - Updated `test_create_worklog.py` to correctly mock the new `session` object. - Verified correct behavior using existing tests. Co-authored-by: yj9404 <47413412+yj9404@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Replaced module-level
requests.getandrequests.postcalls with a globalrequests.Session()object to enable HTTP connection pooling. Also updated the unit tests (test_create_worklog.py) to correctly mocksession.getandsession.post.🎯 Why:
The Confluence automation script makes multiple sequential API calls to fetch folders, create folders, and create pages. Each
requests.getorrequests.postcall previously opened and closed a new TCP connection, incurring unnecessary connection overhead. Usingrequests.Sessionenables the underlyingurllib3connection pool, reusing a single TCP connection for multiple requests to the same host, which is significantly faster and more efficient.📊 Measured Improvement:
I created a temporary standalone benchmark script testing
requests.getvsrequests.Session().getover 10 iterations to a test API endpoint (httpbin.org).This aligns with expected performance gains from TCP connection pooling and directly translates to a faster execution time for the
create_worklog.pyscript.PR created automatically by Jules for task 3238674753435825594 started by @yj9404