Refactoring poi snapping code for compatability new library versions - #7
Open
Ramrion wants to merge 3 commits into
Open
Refactoring poi snapping code for compatability new library versions#7Ramrion wants to merge 3 commits into
Ramrion wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I was using your code for snapping to the road graph and it was one of the few options I could find, which in the end helped me a lot, big thanks!. I still encountered a few issues. The old versions of the libraries that the project depends on were not installing correctly.
In this pull request, I've updated the dependencies to their more recent versions. Additionally, I've made necessary changes in the code to ensure compatibility with these updated libraries, for example, the edges of the road graph doesn't always have columns 'from' and 'to', so I replaced them with 'u' and 'v' columns, as they are more common if you download road from
osmnx.The code is now running smoothly without installation errors. I believe these updates will be beneficial for others who might be facing similar issues.