ci: fix Node 22 deploy + remove Supabase knowledge-search#749
Merged
Conversation
Wrangler 4 dropped Node 20 support, which broke the Deploy Wiki and r2-sync workflows. Bump setup-node to 22 across the wrangler and CI workflows.
The Supabase-backed semantic search had no live frontend consumer (site search is Algolia DocSearch; SearchBar.tsx only tweaks aria attributes), and its indexer workflow was failing on main. Remove the supabase/ project, scripts/knowledge-search/, the indexer workflow, the openai and postgres dependencies, and the stale AGENTS.md reference.
Deploying zsh with
|
| Latest commit: |
3f4057c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a98197b9.zsh.pages.dev |
| Branch Preview URL: | https://feature-zsh10-ci-supabase.zsh.pages.dev |
Contributor
|
Size Change: 0 B Total Size: 6.59 MB ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
Pull request overview
Restores CI/deploy compatibility with wrangler@4 by moving CI Node runtimes to Node 22, and removes the unused Supabase “knowledge-search” indexing experiment (Edge Function, migrations, scripts, workflow, and deps) to simplify the repo.
Changes:
- Bumped CI/deploy workflows to run on Node 22 and updated
package.jsonengines.nodeto>=22. - Removed Supabase knowledge-search implementation (Supabase project files, indexer/query scripts + tests, and the indexing workflow).
- Removed
openaiandpostgresdependencies and regeneratedpnpm-lock.yaml.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
supabase/migrations/20260521000000_create_docs_search.sql |
Removes Supabase migration for docs_search vector schema (feature deletion). |
supabase/functions/knowledge-search/index.ts |
Removes Supabase Edge Function for semantic search (feature deletion). |
supabase/config.toml |
Removes Supabase local config (feature deletion). |
supabase/.gitignore |
Removes Supabase-specific ignores (feature deletion). |
scripts/knowledge-search/query.test.mjs |
Removes knowledge-search query script tests (feature deletion). |
scripts/knowledge-search/query.mjs |
Removes knowledge-search query script (feature deletion). |
scripts/knowledge-search/embed-docs.test.mjs |
Removes indexer script tests (feature deletion). |
scripts/knowledge-search/embed-docs.mjs |
Removes indexer script (feature deletion). |
scripts/knowledge-search/collect-docs.test.mjs |
Removes doc collector tests (feature deletion). |
scripts/knowledge-search/collect-docs.mjs |
Removes doc collector/chunker logic (feature deletion). |
pnpm-lock.yaml |
Drops openai/postgres lock entries after feature removal. |
package.json |
Removes knowledge-search scripts/deps and raises Node engine requirement to >=22. |
AGENTS.md |
Removes the specific runbook reference related to the removed feature. |
.github/workflows/r2-sync.yml |
Updates workflow runtime to Node 22 for wrangler compatibility. |
.github/workflows/pages-deployment.yml |
Updates deploy workflow runtime to Node 22 for wrangler compatibility. |
.github/workflows/knowledge-search-index.yml |
Deletes the knowledge-search indexing workflow. |
.github/workflows/ci-perf.yml |
Updates perf CI workflow runtime to Node 22. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Follow-up to the wrangler@4 Node bump: the Trunk Check composite action still installed deps under Node 20, mismatching engines.node >=22. Bump it and update the AGENTS.md prerequisite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recovers wiki CI and removes the unused Supabase knowledge-search experiment. Tracked in Linear ZSH-10.
wrangler@4dropped Node 20 support, which broke Deploy Wiki and r2-sync. Bumpedsetup-nodeto 22 inpages-deployment.yml,r2-sync.yml, andci-perf.yml, andengines.nodeto>=22.src/theme/SearchBar.tsxonly tweaks aria attributes. Its indexer workflow was also failing onmain. Removedsupabase/,scripts/knowledge-search/, theknowledge-search-index.ymlworkflow, theopenai+postgresdeps and their package scripts, regeneratedpnpm-lock.yaml, and dropped the staleAGENTS.mdreference.Follow-ups (not in this PR)
SUPABASE_URL/SUPABASE_DB_URL/SUPABASE_SECRET_KEY/SB_SECRET_KEY/OPENAI_API_KEY(if unused elsewhere) and decommission the Supabase project.runbooks/supabase-knowledge-search.mdrunbook inz-shell/.github(separate repo).main—mainstays red until this is promoted.nextandmainhave diverged (mainis ahead by 8 hotfix commits), so the promotion needs reconciliation (see ZSH-10 T3).Test plan
main: Deploy Wiki succeeds on Node 22