fix(wiki): broken intro metrics images + missing homepage star count#751
Merged
Conversation
… width The intro page Summary images pointed at z-shell/.github @main, but the metrics SVGs are published to the 'metrics' branch (404 on main → broken images). The homepage star iframe was 130px wide, clipping the count bubble on the large button. Point the URLs at the metrics branch and widen the star iframe to 170px (matching the follow button).
Deploying zsh with
|
| Latest commit: |
792c851
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1947f80f.zsh.pages.dev |
| Branch Preview URL: | https://bug-intro-images-star-count.zsh.pages.dev |
Contributor
|
Size Change: 0 B Total Size: 6.59 MB ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes two UI regressions on the Docusaurus site: broken metrics images on the Introduction page and a clipped GitHub star-count button on the homepage banner.
Changes:
- Update
docs/index.mdxmetrics image URLs to point at the.githubrepo’smetricsbranch (instead ofmain) where the workflow publishes them. - Increase the homepage GitHub “star” iframe width so the star count bubble is visible.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/HomeBanner/index.tsx | Widens the GitHub star button iframe to prevent clipping of the count. |
| docs/index.mdx | Repoints “Summary” metrics SVG URLs to the metrics branch to avoid 404s. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated UI bugs reported on the live wiki.
1. Broken images on the Introduction page (
docs/index.mdx)The "Summary" metrics SVGs referenced
z-shell/.github@main, but themetrics.ymlworkflow publishes them to the dedicatedmetricsbranch (committer_branch: metrics). ThemainURLs 404. Repointed to themetricsbranch.…/.github/main/metrics/plugin/metrics.svg→ 404…/.github/metrics/metrics/plugin/metrics.svg→ 200 ✓2. Missing star count on the homepage GitHub button (
HomeBanner)Not a CSP issue. The star iframe (
type=star&count=true&size=large) waswidth={130}, which clips the count bubble. Widened to170(matches the adjacent follow button).Test plan