Skip to content

build(deps): allow ESLint 10 for jsx-a11y peer (silence install warning)#752

Merged
ss-o merged 1 commit into
nextfrom
bug-eslint-peer-rule
May 26, 2026
Merged

build(deps): allow ESLint 10 for jsx-a11y peer (silence install warning)#752
ss-o merged 1 commit into
nextfrom
bug-eslint-peer-rule

Conversation

@ss-o
Copy link
Copy Markdown
Member

@ss-o ss-o commented May 26, 2026

Summary

ZSH-11 follow-up. ESLint 10 is the current stable major (verified via Context7) and lint passes on it. The only install-time peer warning comes from eslint-plugin-jsx-a11y@6.10.2, whose declared peer caps at ^9. Adds a scoped pnpm peer rule allowing eslint 10, silencing the warning without downgrading off current stable.

  • @docusaurus/eslint-plugin already declares eslint: >=6 — no rule needed (the earlier "^6-8" reading was imprecise).
  • Lockfile unchanged (peer rules don't affect resolution).

Test plan

  • pnpm install no longer warns about jsx-a11y/eslint peer
  • Trunk Check green (lint still works on eslint 10)

ESLint 10 is the current stable major and lint passes on it. eslint-plugin-jsx-a11y@6.10.2 still declares a peer cap of <=9, producing an install-time unmet-peer warning. Add a scoped pnpm peerDependencyRules allowance so the warning is silenced without downgrading off current stable. (@docusaurus/eslint-plugin already declares >=6, so no rule needed there.)
Copilot AI review requested due to automatic review settings May 26, 2026 03:16
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying zsh with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a84f55
Status: ✅  Deploy successful!
Preview URL: https://277d47f0.zsh.pages.dev
Branch Preview URL: https://bug-eslint-peer-rule.zsh.pages.dev

View logs

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the pnpm workspace configuration to silence an install-time peer dependency warning by explicitly allowing ESLint 10 for eslint-plugin-jsx-a11y, without changing dependency resolution or the lockfile.

Changes:

  • Add a peerDependencyRules.allowedVersions entry allowing eslint-plugin-jsx-a11y to accept eslint@^10.

Comment thread pnpm-workspace.yaml
serialize-javascript: "7.0.5"
uuid: "14.0.0"

# Allow ESLint 10 (current stable) for plugins whose declared peer range
@ss-o ss-o merged commit 4c41b11 into next May 26, 2026
7 checks passed
@ss-o ss-o deleted the bug-eslint-peer-rule branch May 26, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants