Guard fileStorage against concurrent writers with a heartbeat lock and unique temp files - #547
Merged
Merged
Conversation
…d unique temp files fileStorage now acquires an exclusive <path>.lock before loading, so a second instance or process on the same path fails at construction naming the holder instead of overwriting a stale snapshot. The holder refreshes the lock every 15 seconds and a heartbeat older than 60 seconds expires regardless of pid, so a container restart that reuses a pid cannot wedge the deployment; within the same host and pid namespace a dead pid is reclaimed immediately, and an in-process registry tells a previous incarnation apart from a second opener. Stale-lock recovery is serialized through an age-limited guard. Writes prove ownership before changing state; reads use the loaded snapshot. Each write uses a unique exclusively created temp file. The JSON format is unchanged and close() releases the lock, as does process exit (#542). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #542.
fileStorageacquires an exclusive<path>.lockbefore loading. A second instance or process on the same path fails at construction naming the holder instead of overwriting a stale snapshot..lock.reclaimguard. Writes prove ownership before changing state and before rename; reads use the loaded snapshot.close(); process exit also releases the lock.Full
npm run checkpasses on this branch.🤖 Generated with Claude Code