Skip to content

Follow the default branch and budget the proof job for both phases - #60

Merged
TheLazyCat00 merged 2 commits into
mainfrom
claude/github-action-ambiguity-65a9aa
Aug 17, 2026
Merged

Follow the default branch and budget the proof job for both phases#60
TheLazyCat00 merged 2 commits into
mainfrom
claude/github-action-ambiguity-65a9aa

Conversation

@TheLazyCat00

Copy link
Copy Markdown
Member

Two small fixes to the ambiguity workflows. The second is the one that matters.

Point both workflows at the default branch

ref defaulted to essential/parser in ambiguity-search.yml and ambiguity-prove.yml. That branch is stale and due for deletion, and it has no .github/scripts/ directory, so a search dispatched at its own default would fail after paying for checkout, Devbox, the opam bootstrap and the build. Both now default to main.

Budget the proof job for a timeout that bounds both phases

#59 gave the abstract proof a deadline of its own, so --timeout now applies to each search phase rather than only to the concretization search. Two comments here described the old behaviour, and one of them was load-bearing.

The input is relabelled per phase, since a run picking 30m is asking for up to an hour of searching rather than half of one.

The job cap has to clear that. At timeout-minutes: 60 it sat exactly on the worst-case search total, with nothing left for checkout, Devbox, the opam bootstrap or the build — so the largest offered timeout would have been killed mid-run. A killed job writes no verdict line, so the report ambiguity-verdict reads its answer out of is never written, and it fails closed at status 2: a broken run, where the honest answer was "not proven".

That is the failure #59 set out to remove from the engine. Leaving the cap at 60 would have reintroduced it one layer up, which is why this is not just a comment refresh. Raised to 75.

Note on the branch

The branch was auto-deleted when #58 merged, so it is restarted from current main with the unmerged ref commit reapplied rather than stacked on already-merged history.

Verification

YAML parses and the three changed values read back as intended (timeout-minutes: 75, ref default main in both workflows, Timeout per search phase). No code changes, so build-and-test covers nothing here; the real check is a dispatch, and run 32063418332 is currently exercising the prove workflow on main — though at 15m, not the 30m case this fixes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01N4KejxPN4Q9uQ67dHwUDgj


Generated by Claude Code

claude added 2 commits August 17, 2026 20:00
Both workflows offered essential/parser as the revision to check out, a
branch that has outlived its purpose and is due to be deleted. Neither
would have run against it: the branch predates .github/scripts entirely,
so the step that invokes the runner script would fail on a missing file.
That made the search workflow unusable at its own default, and the proof
workflow inherited the same default from it.

Both now offer main, which is where the grammar lives.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N4KejxPN4Q9uQ67dHwUDgj
#59 gave the abstract proof a deadline of its own, so --timeout applies to
each search phase rather than only to the concretization search. Two comments
here described the old behaviour, and one of them was load-bearing.

The input is now labelled per phase, since a run picking 30m is asking for up
to an hour of searching rather than half of one.

The job cap has to clear that. At 60 minutes it sat exactly on the worst-case
search total with nothing left for checkout, Devbox, the opam bootstrap or the
build, so the largest offered timeout would have been killed mid-run -- and a
killed job writes no verdict line, so ambiguity-verdict fails closed at status
2 and an honest "not proven" is reported as a broken run. That is the failure
#59 set out to remove; leaving the cap here would have reintroduced it one
layer up.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N4KejxPN4Q9uQ67dHwUDgj
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@TheLazyCat00, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: zane-lang/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 423dd2db-98a1-44e6-9a96-677f5f7eafdd

📥 Commits

Reviewing files that changed from the base of the PR and between 043f009 and 36b8e3f.

📒 Files selected for processing (2)
  • .github/workflows/ambiguity-prove.yml
  • .github/workflows/ambiguity-search.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TheLazyCat00
TheLazyCat00 merged commit bb4f747 into main Aug 17, 2026
2 checks passed
@TheLazyCat00
TheLazyCat00 deleted the claude/github-action-ambiguity-65a9aa branch August 17, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants