Extract ome module - #78
Conversation
- Replace experimental.ome package refs with dev.zarr.omezarr - Add zarr-java-ome as separate Maven/Gradle dependency - Fix write example syntax and imports Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
normanrz
left a comment
There was a problem hiding this comment.
Very high-level feedback. I would rename the modules:
zarr-java-core->zarr-javazarr-java-ome->omezarr-java
I don't think the notebooks need to be in the repository. Please remove.
@sbesson @melissalinkert Do you have some feedback on splitting up into 2 modules/jars?
|
I don't have a problem in general with splitting into separate submodules, though it would be useful to know why this is necessary. I'm not yet using I think my main concern is with artifact IDs. All of the |
|
@joshmoore Can you please elaborate the motivation for splitting up the jars? |
|
I'm running short on time so a immediate few thoughts:
In terms of existing models, I was largely thinking about https://github.com/zarrs/ome_zarr_metadata . That being said, I think there's definitely more than one way to do it, I would just make it feel intentionally to members of both communities. |
|
Thanks @joshmoore. I think this comes down to whether it confuses people that the OME-Zarr metadata is in the zarr-java artifact or not. From the pov of an OME-Zarr implementation it is of course more convenient to have it in a single artifact; I got that feedback a couple of times now.
I don't think the release numbers of zarr-java have to correlate with either the zarr format nor OME-Zarr versions. Why would there be any blocking?
Fair enough. But it doesn't hurt unless it requires additional dependencies.
Maybe it should move under |
|
Echoing @melissalinkert's comments above, my biggest piece of feedback is "let's not rename things (package, artifacts....) unless we have identified a clear rationale and well-identified benefit for users". The The biggest point of discussion started by this contribution is whether The most essential requirement from our side is to ensure we can maintain and rely upon a robust reference Zarr library for the JVM, as was originally discussed during the [2022 OME community meeting] (https://www.openmicroscopy.org/events/ome-community-meeting-2022/). When it comes to adding OME-Zarr support, using either one artifact with multiple packages or having multiple artifacts are both fine strategies for which we are working precedents. If we decide to use multiple artifacts, I have a preference for splitting the OME Zarr implementation in a separate downstream repository and versioning it separately instead of using a multi-module project. |
Restructured zarr-java into two Maven submodules,
zarr-java-coreandzarr-java-ome, making OME-Zarr an optional import.Also adds Jupyter notebooks under
notebooks/for exploring the librarylocally without having to publish changes to Maven Central. Run with
./notebooks/start.sh.Naming convention change: the OME package moved from
dev.zarr.zarrjava.experimental.ometodev.zarr.omezarr.Updated
USERGUIDE.mdandUSERGUIDE-OME-ZARR.mdfor the new module layout,package names, and dependency coordinates.