Skip to content

[ZEE-11536] prod for palantir-foundry.yml - #67

Merged
jonathanlebon-hcl merged 3 commits into
mainfrom
ZEE-11536/palantir-datasource
Jul 30, 2026
Merged

[ZEE-11536] prod for palantir-foundry.yml#67
jonathanlebon-hcl merged 3 commits into
mainfrom
ZEE-11536/palantir-datasource

Conversation

@lionelv-actian

@lionelv-actian lionelv-actian commented Jul 28, 2026

Copy link
Copy Markdown

ZEE-8853 draft for ellipsys-datastage.yml

JIRA Issue

Summary

📝 Description of what was actually done as part of this PR.

QA

📝 Description of the tests to be carried out to ensure there is no regression in existing functionality.

📝 Description of the tests to be carried out to ensure the new features work correctly.

(N/A if not necessary)

Checklists

Developers

  • I have documented the Summary section
  • I have documented the QA section
  • I have manually tested the QA scenarios locally
  • I have requested reviewers
  • I have addressed the feedback
  • I have cleaned up the commit history

Reviewers

  • I have manually tested the QA scenarios locally
  • I have statically reviewed the code, submitted my comments, and possibly requested changes
  • I have verified that all comments have been addressed

[ZEE-8853] draft for ellipsys-datastage.yml
@lionelv-actian
lionelv-actian requested a review from a team as a code owner July 28, 2026 07:09

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather put ellipsys-datastage in an other branch. And the duckdb in the datasource identifier seems strange

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fact is connector-commons needs it according to main, but it was not there... and since it's in draft...

identification:
keys:
- rid
- prefix

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't prefix positioned before rid ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- project_id
- job_id

@jonathanlebon-hcl
jonathanlebon-hcl merged commit e82bbf1 into main Jul 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants